-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support passing zlibOptions and brotliOptions #113
Conversation
This is great, thanks! Can you add the tests and docs? |
I will try to when I have time! I just wanted to get it started, so at least there's something to go off of in case someone else has more time. I'm currently working upwards of 90 hours per week. I just happen to be using this library, and saw this issue when I ran into a weird problem with Brotli compression. I disabled Brotli in the project I'm working on because it's not necessary. I wish I had more time to contribute. I love the open-source community. Great stuff! |
Ouch, I'm sorry for your 90 hours. Thanks for the contribution! |
hi there! I can take a swing at adding docs and tests, if that's alright. |
@chasingSublimity go for it! 👍 |
Ok, here's a first pass. I'm new to Fastify, TypeScript, and zlib so happy to make any improvements you all suggest. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Does someone want to run benchmarks, just in case? |
Not needed here, thanks for checking! |
#106
This does not include tests or a benchmark - just wanted to quickly throw together a first-step in the direction of completing this issue: #106
This also does not include documentation, simple example is as follows:
Checklist
npm run test
andnpm run benchmark